setLanguage() - v1.2 changements - Githubissues

Tiqa / redux-polyglot

Polyglot.js bindings for Redux

MIT License

58 stars 13 forks source link

setLanguage() - v1.2 changements #38

Closed guillaumearm closed 7 years ago

guillaumearm commented 7 years ago

We need to think about actions and the purpose of polyglotMiddleware.

I think redux-polyglot should work with the middleware ONLY. so actions creators too.

some changes :

make setLanguage() a private function (don't expose it)
add setLocale() action creator : middleware will catch this new action, and call getPhrases() with the given locale
- reducer should be impacted by SET_LANGUAGE, not SET_LOCALE.
catch SET_LOCALE in middleware and bypass the getLocale step.

that's all folks.