Closed guillaumearm closed 7 years ago
PR here #56
npm install @Tiqa/redux-polyglot is from scoped npm package, not from Github. Any other reason to include dist on repo @guillaumearm ?
sorry for the '@', just a mistake.
So about the dist folder, I recommend a postinstall script and build only when dist
is missing to prevent for broken installation.
Yes, as we discussed, I prefer the postinstall solution, which does not need us to version /dist.
postinstall example script here: https://github.com/guillaumearm/redux-viewport/blob/master/scripts/postinstall.js
for allowing to install pre-releases with
npm install Tiqa/redux-polyglot
, dist folder should be pushed.take a look here : https://github.com/guillaumearm/redux-with-selectors/commit/8c220f4b36e62debaad684d1a476a1e79808e9eb