search

Tiqa / redux-polyglot

Polyglot.js bindings for Redux
MIT License
58 stars 13 forks source link

dist folder should be pushed on github #53

Closed guillaumearm closed 7 years ago

guillaumearm commented 7 years ago

for allowing to install pre-releases with npm install Tiqa/redux-polyglot, dist folder should be pushed.

take a look here : https://github.com/guillaumearm/redux-with-selectors/commit/8c220f4b36e62debaad684d1a476a1e79808e9eb

guillaumearm commented 7 years ago

PR here #56

JalilArfaoui commented 7 years ago

npm install @Tiqa/redux-polyglot is from scoped npm package, not from Github. Any other reason to include dist on repo @guillaumearm ?

guillaumearm commented 7 years ago

sorry for the '@', just a mistake.

So about the dist folder, I recommend a postinstall script and build only when dist is missing to prevent for broken installation.

JalilArfaoui commented 7 years ago

Yes, as we discussed, I prefer the postinstall solution, which does not need us to version /dist.

guillaumearm commented 7 years ago

postinstall example script here: https://github.com/guillaumearm/redux-viewport/blob/master/scripts/postinstall.js