search

Tiqa / redux-polyglot

Polyglot.js bindings for Redux
MIT License
58 stars 13 forks source link

Importing proptypes from prop-types instead of from react #80

Closed 0xClpz closed 7 years ago

0xClpz commented 7 years ago

import { PropTypes } from 'react'; is now deprecated. import PropTypes from 'prop-types'; should be used instead

guillaumearm commented 7 years ago

Hi, thank you for contributing to redux-polyglot

Can you update package.json react version to 15.5.0 in peerDependencies and add prop-types in dependencies ?

0xClpz commented 7 years ago

Done! :-) I also updated the devDependency to react 15.5.0 You dont need to declare prop-types in your dependencies as it comes with react. (at least in 15.5.0)

No problem, thanks for your library, it was the perfect fit for our current project.

Tell me if theres anything else that should be changed.

guillaumearm commented 7 years ago

It's good for me. thanks again for your contribution :)

guillaumearm commented 7 years ago

@0xClpz, I just release redux-polyglot@0.5.2, so you can upgrade it on your project ;-)

0xClpz commented 7 years ago

Hey Guillaume! Thanks, will do.