Tiqr / tiqr-server-libphp

A PHP library for using the tiqr authentication mechanism
6 stars 7 forks source link

Remove unused LDAP storage solution #29

Closed MKodde closed 2 years ago

MKodde commented 2 years ago

The UserStorage and UserSecret storage both sported a LDAP implementation. This was not used, an probability of it ever being used was so small that removing it was the way to go!

While at it, I also removed the feature where the factories could create 'any' class by passing the FQN of the class to the factory method.

This also has no use case in our own implementations. And when other consumers feel they need to implement another service/storage type. They are welcome to contribute a concrete implementation of that type.

https://www.pivotaltracker.com/n/projects/1163646/stories/181525748