search

TireSwingSoftware / openassign-server

OpenAssign server intended for use by a separate client via RPC
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

ExamSessionManager.create() should not return rejoinders #86

Closed mhrivnak closed 12 years ago

mhrivnak commented 12 years ago

When calling ExamSessionManager.create() with fetch_all=True, the returned data structure includes the rejoinders. Rejoinders should not be sent to the user until after they have submitted a response.

With the current setup, if a user was watching traffic with something like FireBug, they could easily see the rejoinders before having to answer the question.

jc0n commented 12 years ago

This applies to resume() review() and finish() as well. Basically anything calling _get_next_questions()

jc0n commented 12 years ago

@mhrivnak: You may want to review this changeset but it is otherwise good to go.

mhrivnak commented 12 years ago

This code (not your changes, but the whole class in general) is particularly difficult to fully understand without spending substantial time digesting. Nothing stands out as objectionable, but I'm not going to invest that digestion time right now if you feel confident in the changes. If the return value has the same structure except for leaving out rejoinders when they shouldn't be present, and you feel good about the changes, then I give my blessing!