search

Tirraa / dashboard_rtm

dashboard_rtm
MIT License
5 stars 1 forks source link

[Dashboard] Sidebar codebase flexibility #1

Closed gustaveWPM closed 1 year ago

gustaveWPM commented 1 year ago

I noticed the sidebar does not adjust its size when I modify the value of sidebarIconSizeInPx in SidebarButtonStyle.ts

I think that it's way too much hard-coded and would be more elegant if the sidebar dims were binded to this value (or something like).

gustaveWPM commented 1 year ago

I'll think about it when I'll be working on the Dashboard. For now, I would like to focus on the blog & i18n features.

gustaveWPM commented 1 year ago

Fixed in https://github.com/Tirraa/dashboard_rtm/commit/d8562f41094c4aef86575c94a646f304c9c0deee

gustaveWPM commented 1 year ago

Oooooppps: https://github.com/Tirraa/dashboard_rtm/commit/20279cc41e4f3f12cc17731ecd58a40f2a1988ef