Closed Tiryoh closed 2 months ago
The updates to the entrypoint.sh
scripts across multiple versions (foxy, humble, iron, jazzy) incorporate a workaround for an issue related to Docker image creation using the "docker commit" command. The scripts now include logic to check for and remove certain lock files before starting the VNC server and have removed previous notes advising users to log out before committing a Docker container. Additionally, the iron
script notes the security-opt flag requirement for Ubuntu Jammy.
File | Change Summary |
---|---|
foxy/entrypoint.sh |
Added Docker commit workaround, removed specific lock files, adjusted comments and keywords. |
humble/entrypoint.sh |
Added Docker commit workaround, included lock file removal, removed log-out note. |
iron/entrypoint.sh |
Added Docker commit workaround, included lock file removal, added note on security-opt flag for Ubuntu Jammy, removed log-out note. |
jazzy/entrypoint.sh |
Added Docker commit workaround, removed log-out note. |
🐰 Amidst the lines of code so vast,
We’ve crafted scripts to hold steadfast.
Lock files now swiftly disappear,
Docker commits have nothing to fear.
Foxy, Humble, Iron, Jazzy—oh so fast!
Onward, we make solutions ever so clear. 🚀
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Add workaround for issue when image is created with "docker commit"
Thanks @SaadRana17!
https://github.com/Tiryoh/docker-ros2-desktop-vnc/issues/131#issuecomment-2184156856
Summary by CodeRabbit
Bug Fixes
Improvements