TisRyno / LethalProgression

All-client required version of Lethal Experience. Skillpoints and more.
1 stars 1 forks source link

[BUG] Reducing carry weight cause random total weight carried when picking up any modded 0lb scrap #32

Open chibranche opened 5 months ago

chibranche commented 5 months ago

When using latest version, any number of point put into "strength" skill cause strange behaviour when picking up some modded scraps.

Player either has a negative total weigth and move at extreme speed or has a huge weight and can't move at all

When investigating, we found this only applies to scrap with no weight (weight = 0lbs)

Configuration for Strength skill is a multiplier of 0.25 (should this be an integer ?)

Will test further and take a look into the code to see if I can make a PR to solve this

TisRyno commented 5 months ago

Hi @chibranche

Your best bet is to export the logs and search for the logging made here https://github.com/TisRyno/LethalProgression/blob/3d28f3ca2c1d275816917312e8d6667f14060d79/LethalProgression/Skills/Strength.cs#L43-L44

This should see if is an issue with this mod or other mods.

As for the question with configuration; no, it should not be an integer, the multiplier represents a percentage value out of 100. In the scenario of 0.25 it means 1 point in Strength will equal a 0.25% reduction in weight, meaning to have 100% reduction in weight you would need to put in 400 points into Strength.

Personally when playing with the mod I have set the multiplier to 0.5 or 0.75 as I think 0.25 is too low.

If you can post logs of the carry weight I will investigate more, I think I can spot the issue already but logs will confirm it.