search

Tischel / TPie

FFXIV Dalamud plugin for ring-shaped hotbars
GNU Affero General Public License v3.0
34 stars 16 forks source link

[Bug]: When the only items are nested rings, it forces one to be a quick action (which can't be opened). #34

Closed valkyrieBae closed 2 years ago

valkyrieBae commented 2 years ago

What are you trying to do?

I added five nested rings to my ring, and this caused one of them to be forced as quick action. Given that there is no checkbox available for these, I could not remove it as a quick action.

I think this somehow happened because I initially had gear sets added, and then I removed them all and added nested rings.

What is the expected behavior?

If a nested ring is a quick action, it will allow me to open after hovering.

Or, nested rings disabled as quick actions.

What actually happened?

I ended up with a nested ring as a quick action, which then could not be opened.

Suggested solution

Add some sort of check when items are added/removed so that a quick action isn't currently a nested ring. Or restrict the quick action to a "setter" which will do nothing if a nested ring is passed in. Or just anywhere else in the process, add a check that will automatically remove a nested ring as the quick action if it was somehow set accidentally.

You do you, it's an awesome plugin.

Tischel commented 2 years ago

You can probably fix this by editing the config files manually. I'll work on an actual fix this weekend.

Tischel commented 2 years ago

Also for now you can just start a new ring from scratch and it'll probably work.

valkyrieBae commented 2 years ago

I actually was able to fix it by adding and removing an empty action!

Tischel commented 2 years ago

Fixed the original use case that caused this in v1.3.1.0