TissueEngineeringLab / MyoFInDer

Python interface for automatic calculation of the fusion index in muscle cell cultures
https://tissueengineeringlab.github.io/MyoFInDer/
GNU General Public License v3.0
3 stars 1 forks source link

Quote character incorrectly escaped in startup executable #50

Closed WeisLeDocto closed 4 months ago

WeisLeDocto commented 4 months ago

On Windows 11, I encountered a crash in the myofinder.exe startup executable. A quote character was being escaped by a backslash when providing the path to the folder where MyoFInDer is installed. The path to the installation directory is stored in the registry entry with a trailing backlash, hence the bug. This problem does not appear on my development Windows 10 machine, nor on the GitHub bots. The root of the bug is the following line:

https://github.com/TissueEngineeringLab/MyoFInDer/blob/c32ee7db46b8e1209ebb622426ecb9e1c0cf27a5/src/wix/src/myofinder.cpp#L27

This PR adds a check ensuring that the installation directory does not have a trailing backslash, and removes the backslash if needed.