TissueImageAnalytics / tiatoolbox

Computational Pathology Toolbox developed by TIA Centre, University of Warwick.
https://warwick.ac.uk/tia
Other
375 stars 77 forks source link

example 05 is broken #735

Closed measty closed 11 months ago

measty commented 11 months ago

Description

05 example notebook fails when run in colab

What I Did

Opened example 05 in colab and ran it (after restarting runtime once toolbox etc is installed as per instructions)

Reason

Some changes to overlay_prediction_mask() to make a previously non-required argument to now be a required keyword argument (return_ax) mean this notebook no longer works.

shaneahmed commented 11 months ago

Does it work with the stable release? If not then we need a hotfix otherwise we can fix it on the develop branch.

measty commented 11 months ago

it seems to work on release. if i replace the tiatoolbox install line in the notebook with: !pip install git+https://github.com/TissueImageAnalytics/tiatoolbox.git@v1.4.1 | tail -n 1 it will run correctly

measty commented 11 months ago

fixed in #736