TissueImageAnalytics / tiatoolbox

Computational Pathology Toolbox developed by TIA Centre, University of Warwick.
https://warwick.ac.uk/tia
Other
375 stars 77 forks source link

:hammer: Add `mypy` Checks #740

Closed Jiaqi-Lv closed 10 months ago

Jiaqi-Lv commented 10 months ago

Files added:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1d3f039) 99.85% compared to head (d7d0450) 99.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #740 +/- ## ======================================== Coverage 99.85% 99.85% ======================================== Files 65 65 Lines 7520 7532 +12 Branches 1461 1461 ======================================== + Hits 7509 7521 +12 Misses 4 4 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shaneahmed commented 10 months ago

@Jiaqi-Lv Please can you fix the coverage? The if statement only covers once condition in tests. Try modifying the tests to cover this scenario. https://app.codecov.io/gh/TissueImageAnalytics/tiatoolbox/pull/740/blob/tiatoolbox/utils/transforms.py#L110