TissueImageAnalytics / tiatoolbox

Computational Pathology Toolbox developed by TIA Centre, University of Warwick.
https://warwick.ac.uk/tia
Other
340 stars 71 forks source link

🐛 Fix `json_extract` Construction #772

Closed measty closed 5 months ago

measty commented 5 months ago

Restructures the way the dsl builds the SQL expression to access JSON properties so that properties with a . in are correctly treated as a single key

Adds a test to check for correct behaviour when accessing a property containing a .

Addresses issue #771

Would like to check with John if removing json.dumps() is ok. I couldn't see a reason it was necessary and all tests pass/all the use-cases I tried worked fine, but maybe there is one I missed.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0002963) 99.91% compared to head (7003504) 99.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #772 +/- ## ======================================== Coverage 99.91% 99.91% ======================================== Files 69 69 Lines 8518 8518 Branches 1637 1637 ======================================== Hits 8511 8511 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.