Closed vqdang closed 3 months ago
Thanks @vqdang and @John-P Please can you add a simple test to make sure this produces expected results.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.86%. Comparing base (
621a857
) to head (a2c8afe
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please can you also check if it is related to #499 ?
I have added a simple test but not completely sure if it fully tests for the fixed bug. @vqdang @John-P I'd appreciate it if you can give the test a review.
A kind follow up @vqdang @John-P. I'd appreciate it if you can give the test a review. Thanks!
I think this also needs a fix along similar lines for read_rect
A kind follow up @vqdang @John-P. I'd appreciate it if you can give the test a review. Thank you!
I've added a few changes to this PR too.
After updating the sample OME TIFF, the bug can be reproduced using the existing level consistency tests. So, I have removed the newly-added test. This PR should be good to go now.
Emergency bugfix per @John-P request. The culprit is reading bound doesn't use the adjusted bounds as have been done in OpenSlideReader.