search

TissueMAPS / JtLibrary

Please use the https://github.com/TissueMAPS/TissueMAPS instead.
Apache License 2.0
0 stars 2 forks source link

Include non python sources in pkg #12

Closed riccardomurri closed 7 years ago

riccardomurri commented 7 years ago

See commit message of 4333ab0 for more details.

hackermd commented 7 years ago

Thanks Riccardo!

Just a minor point: Could you please set version to 0.3.1rc, so that it is clear that this is not yet officially released.

hackermd commented 7 years ago

Thanks!

What is the reason for moving Python code out of /src/python?

I am asking because we use the same structure in jtmodules and tmclient packages. We should then change the structure of these repositories as well.

riccardomurri commented 7 years ago

What is the reason for moving Python code out of /src/python?

I was not able to find a combination of options for setup.py/setuptools that would pick Python code in src/python and also include non-Python files from parallel directories. Despite what documentation says, tools do not seem to handle this case.

hackermd commented 7 years ago

Ok! I'll merge this. Could you please apply the same changes to the other two repos (jtmodules and tmclient) as well?

hackermd commented 7 years ago

Modules filter and segmentation were left in src/python/jtlib. I included them into the new package location with d39ed5e7f947a4cf287af8f1d842b914249cd7d5.

hackermd commented 7 years ago

@riccardomurri Wait! Why do you actually want to distribute non-Python source files together with the Python package? If somebody wants to use the Matlab code, he can simple clone the repository and add the directory to the Matlab path.