search

TitanNano / TS4ControlAnySim

mod for The Sims 4 to control any NPC sims
Apache License 2.0
48 stars 12 forks source link

removing selectable sims can cause UI Exception #20

Closed ghost closed 4 years ago

ghost commented 4 years ago

Doesn't seem to affect the use of the mod, but this UI Exception is created occasionally because of it. lastUIException.txt

TitanNano commented 4 years ago

@RuralFPSGamer I got a report about this exception before, but am not able to reproduce it myself. Is this still occurring regularly?

ghost commented 4 years ago

@TitanNano yeah it happens almost every time I use the mod to control a sim, but it doesn't seem to affect the gameplay any. I thought maybe it was just when I left the lot or shut down while still having control, but I also see it just controlling a sim for a moment to make them do something then stopping control. I haven't tested it unmodded yet though or if that even matters with a UI exception. I don't deal with UI exceptions much.

ghost commented 4 years ago

It might be pack related maybe? Unless you have all the packs.

TitanNano commented 4 years ago

I have all the packs 😉️

ghost commented 4 years ago

I finally got around to doing another test in a newly created game with only your mod in and no others. Same result. So at least I know it's not a conflict with another mod. It's generated from your mod. Here's the latest one. Even if it can't be fixed to not cause that exception, that's fine because the benefits from using it far outway the exception. Especially if it doesn't cause game issues, which it doesn't seem to. lastUIException.txt

TitanNano commented 4 years ago

@TitanNano I see. Thanks for testing this. Did you by any chance notice when exactly the exception occurred? What did you do when the exception happend?

ghost commented 4 years ago

I figured out why I was getting the UIException by playing the game in a window with the sims 4 folder open to watch for exception spawning. The exception occurs if you leave the controlled sim active when selecting "Don't Control Sim" then switch away to another sim after. The active window and picture of the sim no longer being controlled stays after pressing the button and only closes when you switch away to another sim and that causes the error. As long as you remember to switch away to another active sim before pressing the "Don't Control Sim" button on the sim to remove, no error occurs. So I was able to solve it with that workaround.

TitanNano commented 4 years ago

@RuralFPSGamer Awesome! Many thanks for figuring this out. This can be easily fixed.

TitanNano commented 4 years ago

@RuralFPSGamer this issue should be fixed in the latest preview version https://github.com/TitanNano/TS4ControlAnySim/releases/tag/v1.2.0-pre.2

ghost commented 4 years ago

Confirmed. No longer an issue in the pre release version, thanks!

TitanNano commented 4 years ago

This bug now can occur when a sim is released from control while currently controlling another sim. The game always tries to switch away from the active sim which sometimes means it switches to the sim being released. The active sim should only change if it is the subject of the release action.

TitanNano commented 4 years ago

Has been verified as fixed.