search

TitanPlayz100 / teti

Modern Tetris clone with many modes and customisations
https://titanplayz100.github.io/teti/
MIT License
17 stars 4 forks source link

Hold piece scaling + adjustments #2

Closed AStrangePotato closed 2 months ago

AStrangePotato commented 2 months ago

image image

I've changed the sizeCanvas() function to make the hold piece appear with the correct scaling, and allowed a large maximum board size in the html slider. However, the grid lines seem to appear on the pieces at a browser scaling of something other than 100% (which is not an issue in the original). image

Could you please review the code and edit as necessary to hopefully fix the hold piece scaling? I wasn't sure whether to open an issue or a PR for this, but I hope this is okay.

TitanPlayz100 commented 2 months ago

I think removing the rounding stuff from c.width and c.height might be causing the problem with the grid lines showing on the piece, cause then the size isn't and integer. I'm not too sure about this tho because i haven't tested. Also I'll close this because the next update will kinda organise a lot of code so that its easier to modify later.

After the update u can pr with the board height changes and see if the issue is still there.

TitanPlayz100 commented 2 months ago

Alright feel free to make another pull request cause i deecided to push the update now, i believe ur changes are good