search

TitanRO / Issues

0 stars 0 forks source link

Criatura First Class Job NPCs Subino Navi Error #54

Closed njosefbeck closed 6 years ago

njosefbeck commented 6 years ago

Charles mentioned this issue on Discord the other day, and it's something that I've also experienced. I haven't verified this across ALL First Job NPCs on the second floor, but it seems to happen with the Archer one, and potentially the others as well.

Basically when the conversation gets to a point where the Subino NPC is mentioned, the dialogue just freezes, and you're not able to exit out of it, ultimately leading to having to force quit the client.

For the Archer NPC, I was looking at the conversation here and trying to debug.

It seems to have a proper next(); and a proper end;. Throughout the entire file, the only place where quest 14158 is mentioned is right there, so that if statement should resolve to true, though I'm not sure how questprogress() works, and there could be another quest in another file with that ID.

Then I thought maybe there was an issue with the way that was set up. The formatting in between isn't consistent with other places that seem to work for directing a player to a specific NPC (like here, but also the formatting there seems to work fine in other places, so I'm not sure it's that!

Anyway, here are all the places where the Subino NPC is NAVI'd in the re_jobs_academy.txt file, in case it's useful. Maybe someone else will have more luck getting to the bottom of it!

7409 8715 8805 9714 10408 10479

trojal commented 6 years ago

Attempting a fix by adding a close2(), but I didn't test it yet: https://github.com/TitanRO/server/commit/4ebffef9248917a7ca0c60e799b7060270813ea3

njosefbeck commented 6 years ago

Archer NPC is fixed!