TitaniumTigers4829 / offseason-robot-code-2024

AdvantageKit code
Other
0 stars 1 forks source link

Cool aquilla stuff #35

Closed aridavidson001 closed 1 month ago

aridavidson001 commented 1 month ago

Commands: drive commands were already there

Constants

Subsystems

Ishan1522 commented 1 month ago

If you want to make these follow command-based practices I'd look here, here, here, and here. We have never done this b4, so this isn't a requirement for merging

Ishan1522 commented 1 month ago

This pr will not close the cool Aquila stuff issue. I'll outline what I want more in a bit

aridavidson001 commented 1 month ago

i copied the vision subsystem so it's really jank but it builds and stuff with no errors - for some reason super(drive, vision); wasn't working in the shoot commands(something to do with drivecommandbase I think - I tried uncommenting it but it relies on vision a lot), so I commented it out. i really need the shooter and vision subsystems to be done to make these commands work with no errors

Ishan1522 commented 1 month ago

fix da merge conflicts

aridavidson001 commented 1 month ago

i can't until you approve the pr Edit: nvm ill do it in a bit