Tithibots / tithiwa

Automate Web WhatsApp with selenium in python.
MIT License
24 stars 22 forks source link

Create get_my_name() in waobject.py #67

Closed NavpreetDevpuri closed 3 years ago

NavpreetDevpuri commented 3 years ago

for given example it should return "NavpreetDevpuri" chrome_4anjNsew1Y

ZarghamDanial commented 3 years ago

Hey, can you assign this to me?

NavpreetDevpuri commented 3 years ago

@ZarghamDanial Welcome

NavpreetDevpuri commented 3 years ago

Good luck!

ZarghamDanial commented 3 years ago

@NavpreetDevpuri I have created the function to get the name of the user Created a merge request, please look into it.

ZarghamDanial commented 3 years ago

@NavpreetDevpuri please accept the pr before Hacktoberfest ends 😄

ZarghamDanial commented 3 years ago

Hey @NavpreetDevpuri , I am seeing "Ineligible repo" on my hacktoberfest profile for this pr. Can you tell me what could have happened?

NavpreetDevpuri commented 3 years ago

I am sorry. I thought hackoctoberfest is over. So i removed labels from repo. But i again added those labels.

ZarghamDanial commented 3 years ago

There is a window of 15 days or review after merging the pr. Only after those 15 days, the merging is said to be successful in Hacktoberfest. My pr is still showing:

"Ineligible Repository Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR."

Can you once check if you added it back properly please? Thanks!

NavpreetDevpuri commented 3 years ago

understood..... I added only hacktoberfest-accepted and forgot to add hacktoberfest thanks o remind me

ZarghamDanial commented 3 years ago

Hi @NavpreetDevpuri for some reason, the pr at hacktoberfest is still showing the same issue. I am not sure how to resolve it. Can you see if everything's okay for this merging