search

Tithibots / tithiwa

Automate Web WhatsApp with selenium in python.
MIT License
24 stars 22 forks source link

Added join_group(url) to the group.py as per #53 #76

Closed shivam5522 closed 3 years ago

shivam5522 commented 3 years ago

I have tried to create the function. Please check and revert if something is wrong. Thanks

NavpreetDevpuri commented 3 years ago

@shivam5522 good. Try to run it.

shivam5522 commented 3 years ago

Would it be possible for you to run it because I am getting errors due to some modules and I can't understand how to go past them. I've run the function seperately in a python script and it works perfectly fine.

NavpreetDevpuri commented 3 years ago

Would it be possible for you to run it because I am getting errors due to some modules and I can't understand how to go past them. I've run the function seperately in a python script and it works perfectly fine.

Understood. No problem, I suggest you work on https://github.com/Tithibots/tithiwa/issues/66 for now because https://github.com/Tithibots/tithiwa/issues/66 is easier to get started.

shivam5522 commented 3 years ago

I updated the errors again. Can you please check it out?

NavpreetDevpuri commented 3 years ago

You are new to automation just like was once. Here are some tips for you

  1. While automating the task, keep in mind every automation step takes time even milliseconds, so to take care of it we created _wait_for functions.
  2. Whenever trying to contribute to an open-source first of all look at the code base and try to understand similar things in the codebase and get an idea of the basic "structure of the codes". You will surprise how much you can learn by just trying to understand some code written by others.
  3. Always try to run and debug. Specially debug, I started debugging lately and I released if I had started debugging early then I may learn much more in less time.

Also, look at these suggestions

good luck!

shivam5522 commented 3 years ago

Thank you for the tips!