Titor8115 / mandown

man-page inspired Markdown viewer
GNU General Public License v3.0
243 stars 13 forks source link

Update build system and add f/b keys #26

Closed esmil closed 3 years ago

esmil commented 3 years ago

Hi, nice little tool!

I've updated the Makefile so it should hopefully be a little more flexible for distro maintainers to use pkg-config and overwrite variables with make VAR=whatever.

I've tested it with and without pkg-config on buster, sid, focal, rawhide and Archlinux, but unfortunately I don't have access to a Mac so please test that before merging. Plain make should work exactly as before though.

Titor8115 commented 3 years ago

@esmil HEY!!! I so glade someone with more distro makefile experience finally appeared! I'll test it out on the Mac tomorrow.

PS: I didn't use __has_include because overthinking constantly about backward compatibility. (silly me...)

esmil commented 3 years ago

Don't worry. Worrying about using __has_include is not necessarily silly. It just depends on how valuable you think it is that mandown works on old and/or weird systems that doesn't use either gcc or clang.

Titor8115 commented 3 years ago

@esmil I did another test after realizing I set my mac's terminal to automatically connect to my VM Linux. It seems there an issue when running line 124 -include $O/*.d $O/*/*.d or line 132 $O/%/:

The error message is make: *** build/*.d: Is a directory. Stop. I did some search about this error, and it seems to be an issue with OS X's case sensitivity when using directory as value in makefile. I'm not sure if you are familiar with this. I'm still trying to find a solution.

PS: makefile worked like a charm on other Linux distro.

esmil commented 3 years ago

Hmm.. interesting. Maybe try changing line 124 to

include $(wildcard $O/*.d $O/*/*.d)

and make line 132 more explicit with

$O/blender/ $O/parser/ $O/src/:
Titor8115 commented 3 years ago

Yep, I think it was the line 124 that caused the problem. It's working now, I'm doing some additional test. Thanks mate!