search

Titus-Kiplagat / kanban-js-project

MIT License
1 stars 0 forks source link

Fix Popup modal issue #33

Closed evansnyamekye closed 1 year ago

evansnyamekye commented 1 year ago

Adding a class and an ID attribute to the comments button element

Titus-Kiplagat commented 1 year ago

Hi @evansnyamekye ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights ✅ Correct use of Github workflow ✅ No linter error ✅ Popup displaying ✅ Comments adding ✅ All tests are passing👍

Optional suggestions N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.