search

Tiviacz1337 / PizzaCraft

PizzaCraft
8 stars 16 forks source link

[Bug] Missing pizza slice texture, does not load the texture or loses it in Minecraft 1.18.2 #101

Open Billetiado10 opened 12 months ago

Billetiado10 commented 12 months ago

The mod is in its latest version. PizzaCraft-1.18.2-5.1.7.jar Forge Version: 40.2.10

Latest Log: https://mclo.gs/Fwvfi6E Debug Log: https://mclo.gs/hQF9qJ8 Just remove the Immediatelyfast mod from the mod pack Gave this texture error. Scroll down the log and separate the other 233 mods available in the MOD PACK https://mclo.gs/19nu2GW 2023-09-17_23 52 06 2023-09-17_23 52 22 2023-09-17_23 53 09 2023-09-18_00 01 53

embeddedt commented 11 months ago

It seems to render normally for me with just ModernFix and PizzaCraft, and dynamic resources enabled:

2023-09-27_14 16 27

Billetiado10 commented 11 months ago

If it is placed in a frame of the "Quark" mod then you exit and enter the game loading it from scratch, doesn't that error appear? Before I didn't get any texture errors, but I put the pizza pieces in while I was building and when I loaded the mod pack again from scratch, the texture appeared like this. Could it be a problem with another mod?

Billetiado10 commented 11 months ago

I tried creating a new world to see if the error exists, but NO, the error did not appear, apparently it is when the item is in the world or something similar 2023-09-28_01 21 41

embeddedt commented 11 months ago

@Tiviacz1337 I think ModernFix might be revealing a logic issue in your code - when you deserialize a stack's inventory NBT into an ItemStackHandler here the size you provided could get overwritten. When your model code later creates a list under the assumption that there are 10 slots, that list can be overrun if it turns out that there are actually more slots. This then causes an IndexOutOfBoundsException which means the model fails to be baked.

Tiviacz1337 commented 5 months ago

@Tiviacz1337 I think ModernFix might be revealing a logic issue in your code - when you deserialize a stack's inventory NBT into an ItemStackHandler here the size you provided could get overwritten. When your model code later creates a list under the assumption that there are 10 slots, that list can be overrun if it turns out that there are actually more slots. This then causes an IndexOutOfBoundsException which means the model fails to be baked.

Is it the cause of this issue?

embeddedt commented 5 months ago

I think so