search

Tiviacz1337 / Travelers-Backpack

Unique and upgradeable backpacks with customisation, Curios API/Trinkets integration and more!
148 stars 81 forks source link

This mod conflicts with Natures Compass on modded servers on Forge 1.21 #962

Open Jammyleg opened 1 month ago

Jammyleg commented 1 month ago

  1. ALWAYS PROVIDE INFORMATION ABOUT MODLOADER (Fabric / Forge) AND MOD VERSION (For Example 1.19.2-8.2.10) On the Forge modloader I loaded a few basic mods, but whenever I combined Natures Compass and this mod, I will either crash from the natures compass mod or the backpacks mod, but when seperated on the server they work fine.

  2. Describe the bug As I said prior and the error that pops up is Internal Error: io.netty.handler.codec.DecoderException: java.io.IOException: Packet play/clientbound/minecraft:container_set_slot (ClientboundContainerSetSlotPacket) was larger than I expected, found 3 bytes extra whilst reading packet clientbound/minecraft:container_set_slot

  3. Write steps to reproduce the bug Two ways to do it, when testing Natures Compass, have it pick a biome you will instant crash and keep crashing until you delete the compass from your inventory. For the backpacks, just build the basic backpack, when you place the final item in the crafting menu it will crash before you can collect an item.

  4. What is expected behaviour For me to craft the backpacks and use a natures compass in the same server...

  5. Screenshots (If applicable) image

Jammyleg commented 1 month ago

From what I have seen, it semms that this and Natures compass share the same Pack Format if that is of any help

Tiviacz1337 commented 1 month ago

Does it work on singleplayer?

Jammyleg commented 1 month ago

It does work in single player, which is why I found it very strange.

Tiviacz1337 commented 1 month ago

I can't test it. The server on forge do not work in my dev environment, probably because of Forge itself

Tiviacz1337 commented 1 month ago

But it works correctly on singleplayer

Fr0sch13 commented 1 month ago

Hosted Forge 50.0.24 minecraft 1.21 Running both Natures Compass and Traveler's Backpack disconnect-2024-07-18_22.55.34-client.txt disconnect-2024-07-18_22.55.57-client.txt disconnect-2024-07-18_22.56.35-client.txt disconnect-2024-07-18_22.59.05-client.txt

Heres my logs of the crash

Tiviacz1337 commented 1 month ago

Hosted Forge 50.0.24 minecraft 1.21 Running both Natures Compass and Traveler's Backpack disconnect-2024-07-18_22.55.34-client.txt disconnect-2024-07-18_22.55.57-client.txt disconnect-2024-07-18_22.56.35-client.txt disconnect-2024-07-18_22.59.05-client.txt

Heres my logs of the crash

what did you do to get this crash

Fr0sch13 commented 1 month ago

The bug's steps to reproduce are the same as originally reported in this issue.

  1. Have a hosted server with Nature's Compass and Traveler's Backpack loaded.
  2. Acquire materials to craft basic travelers backpack.
  3. Craft traveler's backpack. (You can individually place the items into the crafting table or use the fill recipe option) Order of items does not matter.
  4. Observe the error message provided by @Jammyleg 's Screen Shot
  5. Clicking [Open Report Directory] will provide the logs I posted.

Expected Behavior: Traveler's Backpack should Function no matter the environment its loaded to. Whether it be hosted or local, single player or multiplayer, and agnostic of other mods (IE: I shouldn't have to not use a mod so I can use this one)

Tiviacz1337 commented 1 month ago

I cant tell if its problem with travelers backpack or naturess compass, I will check it soon

Fr0sch13 commented 1 month ago

@Tiviacz1337 I got logs from the other player who also tested this crash with me the other night, as well as tested the crash from Nature's Compass as you can see above. Thank you for taking time to look into this, hopefully we can get them all fixed up on both sides šŸ™Œ

SpyNullExe commented 1 month ago

@Tiviacz1337 I got logs from the other player who also tested this crash with me the other night, as well as tested the crash from Nature's Compass as you can see above. Thank you for taking time to look into this, hopefully we can get them all fixed up on both sides šŸ™Œ

@Tiviacz1337, @Jammyleg Hello! I can't seem to reproduce this bug on my server.

So you're saying on your server you have used these mods - NaturesCompass-1.21-1.11.7-forge & travelersbackpack-forge-1.21-10.0.0, right? Looking at the mod list, I see you also used other mods like Explorer's Compass, but that doesn't seem to be an issue.

Could you please share your Discord tag so I could contact you directly? I'd like to join your server to test it out myself and do proper debugging.

Otherwise, here are a few things you can try:

Reset your configs: Delete the existing configuration files naturescompass-common.toml and travelersbackpack-common.toml to let them regenerate.

Experiment with config values: Try adjusting the configuration settings for both mods to see if specific settings are causing the issue.

Also, could you provide proper server and client logs for any additional error messages or warnings that might offer more context? From the logs provided above, it's hard to pinpoint exactly where this issue is coming from.

SpyNullExe commented 1 month ago

I can't test it. The server on forge do not work in my dev environment, probably because of Forge itself

(NOTE: This happens because that server is in 1.20.4 version. I can pull request fix)