search

Tixit / odiff

Gets a list of differences between two javascript values.
MIT License
88 stars 13 forks source link

It doesn't catch change object type #1

Closed minicuper closed 12 months ago

minicuper commented 7 years ago 
odiff = require 'odiff'

a = {}
b = []

diff = odiff(a,b)
console.log diff
# returns []
fresheneesz commented 7 years ago

Thanks for the note. Would you be willing to create a pull request for this?

katywings commented 7 years ago

I maybe need this so I could look into it :), are you already working on it @fresheneesz ?

fresheneesz commented 7 years ago

I'm not, so feel free to submit a pull request! Let me know of you have any questions.

katywings commented 7 years ago

Thx for the feedback, keep in mind that I first need to check, if this algorithm even works for my usecase. If it does, I will look into it to fix the array<>object comparison

fresheneesz commented 12 months ago

Ok I finally updated to support this.