search

Tixit / odiff

Gets a list of differences between two javascript values.
MIT License
88 stars 13 forks source link

Typescript definition doesn't seem to be correct. #11

Closed dperetti closed 4 years ago

dperetti commented 4 years ago 
import odiff from 'odiff'

odiff.equal()

-> Property 'equal' does not exist on type '(a: any, b: any) => odiffResult[]'

fresheneesz commented 4 years ago

Ah hm, would you mind testing if the following works?

import * as odiff from 'odiff'

dperetti commented 4 years ago

Doesn't work either.

fresheneesz commented 4 years ago

Sorry, I don't use typescript. @tontonrally added the code for that, so maybe he can help? Otherwise you might need to do your own investigating. I'm happy to help. I'd recommend seeing what is inside odiff in the two cases you tried up there (if 'equal' doesn't exist, is it null, is it an emtpy object, something else?)

dperetti commented 4 years ago

👉 https://github.com/Tixit/odiff/pull/12

fresheneesz commented 4 years ago

👉😎👉

fresheneesz commented 4 years ago

Published v1.4.0 with this in it

tontonrally commented 4 years ago

Sorry guys, didn't see that... As it is now fixed, I don't need to dig into. Thanks @dperetti for the fix.

chapmanjacobd commented 4 years ago

type 'rm' has vals: any[]

fresheneesz commented 4 years ago

@chapmanjacobd I think you're right. Would you be willing to write a pull request for that?

chapmanjacobd commented 4 years ago

Ok

On Fri, Jun 5, 2020, 12:57 fresheneesz notifications@github.com wrote:

@chapmanjacobd https://github.com/chapmanjacobd I think you're right. Would you be willing to write a pull request for that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tixit/odiff/issues/11#issuecomment-639275679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4KV2LUL5G4MDK35QGHD4DRVCCLXANCNFSM4J6NVHJA .

fresheneesz commented 4 years ago

Fixed in pull request #19