Tjoms99 / xiao_sense_nrf52840_battery_lib

A battery management library for the XIAO BLE and XIAO BLE Sense board using Zephyr.
Apache License 2.0
23 stars 4 forks source link

Proposal for varios changes #5

Open helicocrasher opened 7 months ago

helicocrasher commented 7 months ago

Hi @Tjoms99

So as propsed lets try a pull request. It is the first one I ever tried, so you might need to be patient.

Main Changes:

Please check which parts you might like.

Cheers

Tjoms99 commented 6 months ago

Good stuff @helicocrasher! Will test the code later, left some comments here for you to think about:) The LEDS are a cool feature but I think we should use it in another way. Maybe we could show the battery status with some charging animation as they do for electric vehicles (is the battery charging, is it charging and at full capacity?); For now, I think we should remove the LEDS. There are some stuff we need to think about here before adding it (user might already be using the LEDS), I can open a new ticket for this:)

Great work.

Tjoms99 commented 6 months ago

Hi @helicocrasher, it has been a while. If you would like some help with the feedback, let me know!