search

TkinterEP / python-tkextrafont

C-extension for Tcl to allow loading custom font files into Tcl/Tk applications, packaged for Python's Tkinter
MIT License
21 stars 3 forks source link

Migrate to pyproject.toml and scikit-build-core #12

Closed mochaaP closed 3 weeks ago

mochaaP commented 8 months ago

build: switch to scikit-build-core, use gitmodules & peru, clarify license build: use prebuilt Tcl/Tk from CPython, fontconfig from vcpkg on win32 msvc ci: add cibuildwheel and dependabot

Tested on py3.12 Feodra Linux

See changes in https://github.com/TkinterEP/python-tksvg/pull/6

TODO:

rdbende commented 8 months ago

Just skimmed through the changes. They mostly look good to me.

fontconfig from vcpkg on win32 msvc

Why is this needed? Extrafont doesn't use fontconfig on Windows, it uses GDI

mochaaP commented 8 months ago

Just skimmed through the changes. They mostly look good to me.

fontconfig from vcpkg on win32 msvc

Why is this needed? Extrafont doesn't use fontconfig on Windows, it uses GDI

Ah I missed that. Will fix it later

rdbende commented 8 months ago

The README mentions it, but I have built extrafont with Visual Studio multiple times, and I can confirm, that fontconfig isn't necessary.

mochaaP commented 8 months ago

cc @rdbende this should be the final changes

mochaaP commented 8 months ago

blocked by https://github.com/actions/runner-images/issues/9441

edit: applied a workaround as described in https://github.com/TkinterEP/python-tksvg/pull/6#issuecomment-1975166725

rdbende commented 3 weeks ago

From others' tests this seems to work fine on Windows as well. Let's see how the CI goes.