Open RedFantom opened 6 years ago
'Black' theme: Spinbox text not visible unless selected. TSpinbox should have same settings as TCombobox and TEntry. (foreground='black', padding=2)
Thanks for reporting this. I have ran across this too but I forgot to report it here.
Adapta:
Spinbox is not styled (you commented out the whole spinbox-part, images missing)
Notebook client is too contrasty, does not fit the theme (you commented out the Notebook.client-part, image missing)
Treview.indicator does not fit the theme (you commented out that part, image missing)
And there are many unnecessary images in the folder.
Aquativo:
The radio and checkbuttons have a different background color when disabled, which is not good (-disabledbackground is missing from the code):
Thank you for reporting these! I've put them on the TODO-list.
I remember working on the Adapta theme and noticing that it lacked some images. I must've forgotten to create them :flushed: .
Do you know if the scrollbars on Mac are style-able?? I've not been able to find a way to make a decent dark themed scrollbar on Mac, and it appears this is the case on ttkthemes as well.
EDIT --- hmm... not sure anything can be done about it presently, but let me know. Here's a fascinating paper on the color issues with MacOS and Tkinter for reference. https://www.tcl.tk/community/tcl2019/assets/talk168/Paper.pdf
What Tk version are you using?
Refering to this issue -> ttk::scrollbar Styling
there was a problem like this before version 8.6.10.
And I know from here that Tk on macOS uses HIToolbox instead of Cocoa for scrollbars. This may also be the cause of this problem, but I don't really know.
EDIT: Yeah, the paper you found explains this better than what I found in the meantime.
Good call. I upgraded via brew and it is now working find.
I still find it odd that python.org still ships with and recommends tcl/tk 8.6.8 on Mac, while Mac ships with 8.6.9 natively, and 8.6.11 is available if you upgrade via brew.
Ugh... wondering if dealing with MacOs is worth the trouble... lol
'Black' theme: Spinbox text not visible unless selected.
Any update on this? It is still broken after pip install --upgrade ttkthemes
@Akuli PR created
@rdbende Thank you, it is merged!
I'd like to request changing the color of the treeview widget so it's all in dark grey.
In several themes, when using icons of bigger sizes, Button widgets don't adapt to contain them, so the icon is partially placed outside the widget. Adding or removing a text label to the button doesn't make any difference, and neither does changing the compound value.
See this picture with the Clearlooks theme on Windows 10:
The issue doesn't happen when styling the button with the
Toolbutton
style, but this changes its look, so it isn't always the best solution.
The affected themes are blue
, clearlooks
, elegance
, kroc
, radiance
, ubuntu
and smog
; all the other themes don't have this issue.
None of the themes provided in this repository are perfect. In fact, most contain some small visual errors, that may only become apparent in specific use-cases. If you spot any, please post a screenshot of the afflicted UI elements here, along with a short description of what you think is off. If you provide a clear example of what is wrong, I will fix the issue!
TODO List
Spinbox
Treeview
ArrowsEntry
and related images forSpinbox
andCombobox
Progressbar
Spinbox
Entry
Combobox
OptionMenu
graphics glitchesNotebook
non-selected tab glitchScale
: Through when setting stickyProgressbar
when setting stickySpinbox
button arrow button alignmentProgressbar
when setting stickyButton
,Checkbutton
,Radiobutton
contrasting backgroundCombobox
button on the right paddingNotebook
: Selected tab markingOptionMenu
,Menubutton
Spinbox
button glitchesProgressbar
when setting stickyCombobox
: small artifact around the button