TkinterEP / ttkthemes

A group of themes for the ttk extenstions for Tkinter
GNU General Public License v3.0
364 stars 47 forks source link

RadioButton not displaying correctly when disabled? #92

Closed TheWicklowWolf closed 8 months ago

TheWicklowWolf commented 1 year ago

This is the radio button normally:

B

When its disabled, this is what it shows: A


This is what it looks like with just tk: C

Any ideas? Thanks

rdbende commented 1 year ago

I think this is a logic bug here:

https://github.com/TkinterEP/ttkthemes/blob/07e6509cc6bffbe7917e6ff456f0d1f16a5de636/ttkthemes/png/yaru/yaru.tcl#L239-L240

disabled will match before selected disabled. The same bug applies to chrckboxes.

TheWicklowWolf commented 1 year ago

I think the correct order should be:

{disabled selected} $I(radio-checked-insensitive) \
disabled            $I(radio-unchecked-insensitive) \
{pressed selected}  $I(radio-checked-pressed) \
pressed             $I(radio-checked-pressed) \
{active selected}   $I(radio-checked-active) \
{pressed !selected} $I(radio-unchecked-pressed) \
active              $I(radio-unchecked-active) \
selected            $I(radio-checked) \