search

TkinterEP / ttkwidgets

A collection of widgets for Tkinter's ttk extensions by various authors
GNU General Public License v3.0
137 stars 28 forks source link

Fix SyntaxWarnings in newer Python 3 releases #86

Closed bartbroere closed 2 years ago

bartbroere commented 2 years ago

Newer Python releases (Python 3.8 in my case) raise SyntaxWarnings for comparing with a literal using is. This should prevent that.

codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (32fc610) into master (9145d17) will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   89.31%   89.49%   +0.18%     
==========================================
  Files          43       42       -1     
  Lines        4032     4018      -14     
==========================================
- Hits         3601     3596       -5     
+ Misses        431      422       -9
Impacted Files Coverage Δ
ttkwidgets/debugwindow.py 87.75% <100.00%> (ø)
ttkwidgets/itemscanvas.py 95.77% <100.00%> (+3.20%) :arrow_up:
ttkwidgets/linklabel.py 96.42% <100.00%> (+7.14%) :arrow_up:
ttkwidgets/validated_entries/numbers.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9145d17...32fc610. Read the comment docs.

elibroftw commented 2 years ago

Damn is this repo dead or something? @RedFantom make someone a maintainer please.

rdbende commented 2 years ago

No, it's not dead, it's just that @RedFantom has been busy for the last year or so, and he doesn't have time for such of hobby programming. I don't know about the others, but it's a pity that there is no one to take care of this project atm.

@RedFantom, perhaps if you could give me write access, I could review the pull requests, I've got quite familiar with TkinterEP stuff and its code.

RedFantom commented 2 years ago

Indeed, I have been extremely busy with other things and have little time to spend on hobby-programming for projects like these.

However, I am open to giving @rdbende write access. The only thing I ask is that things keep being documented and described (documentation on RTD & descriptive commit messages!) so I can review any changes once my time-table becomes a little more flexible again.

RedFantom commented 2 years ago

Thank you very much @bartbroere, @rdbende and @Dogeek ! 👍🏻