search

Tmeister / wp-api-jwt-auth

A simple plugin to add JSON Web Token (JWT) Authentication to WP REST API
GNU General Public License v2.0
549 stars 159 forks source link

Add environment variable support #226

Closed TheGreatRefrigerator closed 1 year ago

TheGreatRefrigerator commented 2 years ago

the JWT_AUTH_SECRET_KEY as well as JWT_AUTH_CORS_ENABLE can be read from environment variables instead of hardcoding in wp-config.php

TheGreatRefrigerator commented 1 year ago

Instead of creating just an issue i contributed a PR. I don't mind it being closed, but could you please leave me the reason for closing? Was it missing something it needs for being considered at all? Or something else?

Tmeister commented 1 year ago

Hi, and thank you for your PR.

As you can see, I closed all the old PRs; it doesn't mean the PRs are wrong, but most lacked context, info, or documentation.

So, to avoid that from now a PR needs to provide that information; when people create a new PR, a template needs to be followed to me test it and get a context and not add code to add it.

That will be helpful for you guys and me.

Best,