Rocking curve reverse ray-tracing might be off by a bit

ToFuProject / tofu

Project for an open-source python library for synthetic diagnostics and tomography for Fusion devices

https://tofuproject.github.io/tofu/index.html

MIT License

69 stars 11 forks source link

Closed dvezinet closed 3 months ago

dvezinet commented 3 months ago

tofu currently implements the rocking assuming specular reflections around bragg's angle
But the way the rocking curve is actually measured (fixed source and detector + rocking crystal) actually suggests it should instead be used otherwise, with the reflected ray at a complementary angle to the incident angle with respect to Bragg's angle.

dvezinet commented 3 months ago

It's just that the implementation has a minor bug, see PR #918