Closed dvezinet closed 4 months ago
Hello @dvezinet! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
tofu/data/_class08_concatenate_data.py
:Line 223:19: E702 multiple statements on one line (semicolon) Line 289:9: E116 unexpected indentation (comment) Line 290:13: E116 unexpected indentation (comment) Line 291:13: E116 unexpected indentation (comment) Line 292:13: E116 unexpected indentation (comment) Line 293:13: E116 unexpected indentation (comment) Line 294:9: E116 unexpected indentation (comment) Line 295:9: E116 unexpected indentation (comment) Line 303:9: E116 unexpected indentation (comment) Line 304:9: E116 unexpected indentation (comment) Line 305:9: E116 unexpected indentation (comment) Line 306:13: E116 unexpected indentation (comment) Line 308:9: E116 unexpected indentation (comment) Line 309:13: E116 unexpected indentation (comment) Line 310:13: E116 unexpected indentation (comment) Line 311:13: E116 unexpected indentation (comment) Line 312:9: E116 unexpected indentation (comment) Line 319:9: E116 unexpected indentation (comment) Line 320:9: E116 unexpected indentation (comment) Line 322:9: E116 unexpected indentation (comment) Line 323:13: E116 unexpected indentation (comment) Line 324:13: E116 unexpected indentation (comment) Line 325:13: E116 unexpected indentation (comment) Line 327:13: E116 unexpected indentation (comment) Line 328:17: E116 unexpected indentation (comment) Line 329:21: E116 unexpected indentation (comment) Line 330:21: E116 unexpected indentation (comment) Line 331:17: E116 unexpected indentation (comment) Line 332:17: E116 unexpected indentation (comment) Line 334:13: E116 unexpected indentation (comment) Line 335:13: E116 unexpected indentation (comment) Line 336:17: E116 unexpected indentation (comment) Line 337:17: E116 unexpected indentation (comment) Line 338:13: E116 unexpected indentation (comment) Line 340:13: E116 unexpected indentation (comment) Line 341:13: E116 unexpected indentation (comment) Line 342:17: E116 unexpected indentation (comment) Line 343:21: E116 unexpected indentation (comment) Line 344:17: E116 unexpected indentation (comment) Line 345:17: E116 unexpected indentation (comment) Line 347:13: E116 unexpected indentation (comment) Line 348:13: E116 unexpected indentation (comment) Line 349:17: E116 unexpected indentation (comment) Line 350:17: E116 unexpected indentation (comment) Line 351:13: E116 unexpected indentation (comment) Line 353:13: E116 unexpected indentation (comment) Line 354:17: E116 unexpected indentation (comment) Line 355:21: E116 unexpected indentation (comment) Line 356:21: E116 unexpected indentation (comment) Line 357:21: E116 unexpected indentation (comment) Line 358:21: E116 unexpected indentation (comment) Line 359:17: E116 unexpected indentation (comment) Line 360:17: E116 unexpected indentation (comment) Line 361:13: E116 unexpected indentation (comment) Line 362:17: E116 unexpected indentation (comment) Line 364:13: E116 unexpected indentation (comment) Line 365:13: E116 unexpected indentation (comment) Line 366:17: E116 unexpected indentation (comment) Line 367:17: E116 unexpected indentation (comment) Line 368:13: E116 unexpected indentation (comment) Line 370:9: E116 unexpected indentation (comment) Line 371:9: E116 unexpected indentation (comment) Line 373:9: E116 unexpected indentation (comment) Line 374:13: E116 unexpected indentation (comment) Line 375:17: E116 unexpected indentation (comment) Line 376:21: E116 unexpected indentation (comment) Line 377:21: E116 unexpected indentation (comment) Line 378:17: E116 unexpected indentation (comment) Line 379:21: E116 unexpected indentation (comment) Line 380:17: E116 unexpected indentation (comment) Line 381:21: E116 unexpected indentation (comment) Line 382:21: E116 unexpected indentation (comment) Line 383:21: E116 unexpected indentation (comment) Line 384:21: E116 unexpected indentation (comment) Line 385:17: E116 unexpected indentation (comment) Line 386:17: E116 unexpected indentation (comment) Line 387:21: E116 unexpected indentation (comment) Line 388:17: E116 unexpected indentation (comment) Line 389:21: E116 unexpected indentation (comment) Line 390:17: E116 unexpected indentation (comment) Line 391:21: E116 unexpected indentation (comment) Line 392:17: E116 unexpected indentation (comment) Line 393:21: E116 unexpected indentation (comment) Line 394:21: E116 unexpected indentation (comment) Line 396:9: E116 unexpected indentation (comment) Line 397:9: E116 unexpected indentation (comment) Line 398:13: E116 unexpected indentation (comment) Line 399:13: E116 unexpected indentation (comment) Line 400:9: E116 unexpected indentation (comment) Line 408:9: E116 unexpected indentation (comment) Line 409:9: E116 unexpected indentation (comment) Line 410:9: E116 unexpected indentation (comment) Line 412:9: E116 unexpected indentation (comment) Line 413:13: E116 unexpected indentation (comment) Line 414:16: E114 indentation is not a multiple of four (comment) Line 414:16: E116 unexpected indentation (comment) Line 415:20: E114 indentation is not a multiple of four (comment) Line 415:20: E116 unexpected indentation (comment) Line 416:20: E114 indentation is not a multiple of four (comment) Line 416:20: E116 unexpected indentation (comment) Line 417:20: E114 indentation is not a multiple of four (comment) Line 417:20: E116 unexpected indentation (comment) Line 418:20: E114 indentation is not a multiple of four (comment) Line 418:20: E116 unexpected indentation (comment) Line 419:16: E114 indentation is not a multiple of four (comment) Line 419:16: E116 unexpected indentation (comment) Line 421:9: E116 unexpected indentation (comment) Line 422:13: E116 unexpected indentation (comment) Line 423:17: E116 unexpected indentation (comment) Line 424:17: E116 unexpected indentation (comment) Line 425:17: E116 unexpected indentation (comment) Line 426:17: E116 unexpected indentation (comment) Line 427:13: E116 unexpected indentation (comment) Line 440:9: E116 unexpected indentation (comment) Line 441:13: E116 unexpected indentation (comment) Line 442:13: E116 unexpected indentation (comment) Line 443:13: E116 unexpected indentation (comment) Line 444:13: E116 unexpected indentation (comment) Line 445:9: E116 unexpected indentation (comment) Line 446:9: E116 unexpected indentation (comment) Line 451:9: E116 unexpected indentation (comment) Line 452:13: E116 unexpected indentation (comment) Line 453:13: E116 unexpected indentation (comment) Line 454:9: E116 unexpected indentation (comment) Line 455:9: E116 unexpected indentation (comment) Line 459:9: E116 unexpected indentation (comment) Line 460:9: E116 unexpected indentation (comment) Line 466:9: E116 unexpected indentation (comment) Line 467:9: E116 unexpected indentation (comment) Line 468:13: E116 unexpected indentation (comment) Line 469:13: E116 unexpected indentation (comment) Line 470:9: E116 unexpected indentation (comment) Line 471:13: E116 unexpected indentation (comment) Line 472:9: E116 unexpected indentation (comment) Line 473:13: E116 unexpected indentation (comment) Line 474:13: E116 unexpected indentation (comment) Line 479:9: E116 unexpected indentation (comment) Line 480:13: E116 unexpected indentation (comment) Line 480:80: E501 line too long (84 > 79 characters) Line 481:13: E116 unexpected indentation (comment) Line 482:17: E116 unexpected indentation (comment) Line 483:13: E116 unexpected indentation (comment) Line 484:17: E116 unexpected indentation (comment) Line 485:17: E116 unexpected indentation (comment) Line 488:9: E116 unexpected indentation (comment) Line 489:9: E116 unexpected indentation (comment) Line 493:9: E116 unexpected indentation (comment) Line 494:9: E116 unexpected indentation (comment) Line 495:9: E116 unexpected indentation (comment) Line 496:13: E116 unexpected indentation (comment) Line 497:13: E116 unexpected indentation (comment) Line 498:9: E116 unexpected indentation (comment) Line 499:9: E116 unexpected indentation (comment) Line 500:13: E116 unexpected indentation (comment) Line 501:17: E116 unexpected indentation (comment) Line 501:80: E501 line too long (80 > 79 characters) Line 502:17: E116 unexpected indentation (comment) Line 503:13: E116 unexpected indentation (comment) Line 504:13: E116 unexpected indentation (comment) Line 509:9: E116 unexpected indentation (comment) Line 510:13: E116 unexpected indentation (comment) Line 511:17: E116 unexpected indentation (comment) Line 512:21: E116 unexpected indentation (comment) Line 513:21: E116 unexpected indentation (comment) Line 514:17: E116 unexpected indentation (comment) Line 515:13: E116 unexpected indentation (comment) Line 516:17: E116 unexpected indentation (comment) Line 517:21: E116 unexpected indentation (comment) Line 518:21: E116 unexpected indentation (comment) Line 519:17: E116 unexpected indentation (comment) Line 520:17: E116 unexpected indentation (comment) Line 521:21: E116 unexpected indentation (comment) Line 522:25: E116 unexpected indentation (comment) Line 523:25: E116 unexpected indentation (comment) Line 524:25: E116 unexpected indentation (comment) Line 525:25: E116 unexpected indentation (comment) Line 526:25: E116 unexpected indentation (comment) Line 527:25: E116 unexpected indentation (comment) Line 528:25: E116 unexpected indentation (comment) Line 529:21: E116 unexpected indentation (comment) Line 530:21: E116 unexpected indentation (comment) Line 537:9: E116 unexpected indentation (comment) Line 538:13: E116 unexpected indentation (comment) Line 539:17: E116 unexpected indentation (comment) Line 540:21: E116 unexpected indentation (comment) Line 541:21: E116 unexpected indentation (comment) Line 542:21: E116 unexpected indentation (comment) Line 543:17: E116 unexpected indentation (comment) Line 544:13: E116 unexpected indentation (comment) Line 545:17: E116 unexpected indentation (comment) Line 546:9: E116 unexpected indentation (comment) Line 547:13: E116 unexpected indentation (comment) Line 549:9: E116 unexpected indentation (comment) Line 552:9: E116 unexpected indentation (comment) Line 562:9: E116 unexpected indentation (comment) Line 563:9: E116 unexpected indentation (comment) Line 564:9: E116 unexpected indentation (comment) Line 568:9: E116 unexpected indentation (comment) Line 569:9: E116 unexpected indentation (comment) Line 570:9: E116 unexpected indentation (comment) Line 571:9: E116 unexpected indentation (comment) Line 572:9: E116 unexpected indentation (comment) Line 573:8: W292 no newline at end of file Line 573:8: W292 no newline at end of file Line 573:8: W292 no newline at end of file
tofu/data/_class08_get_data.py
:Line 134:15: E203 whitespace before ':' Line 179:12: E111 indentation is not a multiple of four Line 545:15: W292 no newline at end of file
tofu/data/_class08_get_data_def.py
:Line 131:15: E261 at least two spaces before inline comment Line 172:9: E303 too many blank lines (2) Line 180:80: E501 line too long (83 > 79 characters) Line 196:18: W292 no newline at end of file
tofu/data/_class08_get_data_vos_broadband.py
:Line 92:38: W292 no newline at end of file
tofu/data/_class08_get_data_vos_spectro.py
:Line 73:38: W292 no newline at end of file
tofu/data/_class2_check.py
:Line 1018:32: W292 no newline at end of file
tofu/data/_class2_compute.py
:Line 905:27: W292 no newline at end of file
tofu/data/_class8_compute.py
:Line 1103:21: W292 no newline at end of file
tofu/data/_class8_los_data.py
:Line 817:30: E225 missing whitespace around operator
tofu/data/_class8_vos.py
:Line 984:80: E501 line too long (91 > 79 characters)
tofu/data/_class8_vos_broadband.py
:Line 321:80: E501 line too long (80 > 79 characters) Line 466:5: E303 too many blank lines (2)
tofu/spectro/_spectralrange2d.py
:Line 81:5: E303 too many blank lines (2) Line 431:35: E221 multiple spaces before operator Line 436:35: E221 multiple spaces before operator Line 802:15: W292 no newline at end of file
tofu/tests/tests01_geom/test_01_GG.py
:Line 1199:80: E501 line too long (94 > 79 characters) Line 1228:80: E501 line too long (81 > 79 characters) Line 1236:80: E501 line too long (84 > 79 characters) Line 2025:33: W292 no newline at end of file
Line 625:20: W292 no newline at end of file
Main changes:
https://github.com/ToFuProject/tofu/pull/916 and https://github.com/ToFuProject/tofu/pull/921
interpolate_along_los(key_diag=str)
now accepts a rays keyinterpolate_along_los()
has better error msg in case of ray with no valid point in the desired range (radius_max
)https://github.com/ToFuProject/tofu/pull/918
get_crystal_bragglamb()
now return the non-corrected bragg angle by defaulthttps://github.com/ToFuProject/tofu/pull/920
spectral_range_2d()
now returns the dict of axes + larger figurespectral_range_2d(varrad_b)
allows to handle variable radii sinusoidal spiral crystalshttps://github.com/ToFuProject/tofu/pull/924
plot_diagnostic_geometrical_coverage()
now :cmap
,vmin
andvmax
from the usernan0
to be set by the user (defaults toTrue
)https://github.com/ToFuProject/tofu/pull/926
get_dvos_xyz()
has more informative error msghttps://github.com/ToFuProject/tofu/pull/928
lamb = None
andres_lamb = None
https://github.com/ToFuProject/tofu/pull/932
c_sqrt()
was applied on a quantity that was 0 within machine accuracy but negative (-2e-17
)NaN
that was propagating in certain special casesc_sqrt(c_abs())
for better robustnesshttps://github.com/ToFuProject/tofu/pull/933
crystal
anddmat
is wronghttps://github.com/ToFuProject/tofu/pull/934
plot_diagnostic_coverage(dax=dict)
works, wit optionally user-specified colorbar axesget_diagnostic_data()
: fully restructured with printing doc on available data + dedicated sub-modules