ToTheBeginning / PuLID

[NeurIPS 2024] Official code for PuLID: Pure and Lightning ID Customization via Contrastive Alignment
Apache License 2.0
2.72k stars 189 forks source link

Python <= 3.8 is not supported #66

Open PRPA1984 opened 2 months ago

PRPA1984 commented 2 months ago

According to the README.md, the required Python version is >= 3.7. I think this is wrong, because the used type annotations are available in Python >= 3.9.

Here is an example

def prepare(t5: HFEmbedder, clip: HFEmbedder, img: Tensor, prompt: str) -> dict[str, Tensor]:

Return type should be replaced by Dict with its corresponding "from typing import Dict" import

def prepare(t5: HFEmbedder, clip: HFEmbedder, img: Tensor, prompt: str) -> Dict[str, Tensor]:
ToTheBeginning commented 2 months ago

Thanks for you suggestion, we change the dependency to Python >= 3.9 now.