ToastWallet / core

This repo contains the core code for Toast Wallet. It is built for iOS, Android and browser directly from this repository. PC builds are built from the browser version using Electron.
GNU General Public License v2.0
210 stars 80 forks source link

[Fix] Treat empty destination tag as null #46

Closed omarish closed 5 years ago

omarish commented 5 years ago

Why?

Currently, when a user tries to make a transaction without specifying a destination tag, the wallet automatically sets the destination tag to a non-null default of 0. This can cause problems because destination_tag=null is different from destination_tag=0.

What?

This PR adds validation and parsing to the destination tag filed so that blank destination tags are coalesced to null.

Demo

See video here: https://youtu.be/Sk16qL6Nt80