search

TobKra96 / music_led_strip_control

Audio visualization for LED strips in real-time with web interface on a raspberry pi.
https://tobkra96.github.io/music_led_strip_control/
MIT License
295 stars 63 forks source link

implemented microphone disable function #160

Closed dr3st closed 2 years ago

dr3st commented 2 years ago

Hello TobKra96,

me again ;) When I used the Microphone settings and set "no Microphone available" it does not mean, to disable the Microphone (to save ressources and performance), but the audio_process_service just choose the first device it can find.

So I worked on it and was able to implement a microphone disable option by skipping the routine, if no device is set. This means to skip the fallback selection as well, but maybe you like to have a look at it?

I think it would be nice to be able to disable the microphone requests, if wanted. Please let me know if you would like to see some modifications on the source code.

Thanks in advance, best regards

Timo

PS: Thank you very much for this project, it is amazing!!!

Teraskull commented 2 years ago

Hi @dr3st,

Please make your changes in the dev_2.3 branch, since the code is changed a long time ago, and the no_mic id does not exist anymore.

The master branch is the stable 2.2 version.

dr3st commented 2 years ago

I close this merge request because of incompetence to rebase :( I create a new one. Sorry!