search

Tobi823 / ffupdater

FFUpdater: Updater for privacy friendly browser
https://f-droid.org/en/packages/de.marmaro.krt.ffupdater
GNU General Public License v3.0
655 stars 32 forks source link

Brave should use Bravearm64Universal.apk instead of BraveMonoarm64.apk #475

Closed celenityy closed 1 year ago

celenityy commented 1 year ago

Is your feature request related to a problem? Please describe. Installing Brave from FFUpdater on certain 64-bit devices like the new Google Pixels results in the app not functioning and crashing on launch.

Describe the solution you'd like I propose that FFUpdater should download Bravearm64Universal.apk where applicable instead of trying to download BraveMonoarm64.apk like it currently does, as Bravearm64Universal.apk isn't broken and functions perfectly on these devices, tested on my Pixel 7 Pro.

chris122380 commented 1 year ago

This would also solve the issues found in

232 and #293

Sepero commented 1 year ago

How did a mistake like this even happen? Of course it should be using the Universal apk

chris122380 commented 1 year ago

How did a mistake like this even happen? Of course it should be using the Universal apk

I used to download Brave directly from GitHub and I didn't realize there was a universal APK. Then when I started digging I realized there's a whole lot more listed under the release downloads then I realized. I'll be manually grabbing the universal until this fix is applied.

Tobi823 commented 1 year ago

@Retold3202 Thanks for the info. Issue is now fixed and will be released in 78.1.5.

Tobi823 commented 1 year ago

@Sepero I know you didn't mean that but the GitHub community is global. You should be careful in your choice of words to prevent misunderstandings (see how different some cultures work https://www.businessinsider.com/the-culture-map-8-scales-for-work-2015-1?op=1). One could understand "How did a mistake like this even happen?" as "How did a mistake like this even happen? Are you stupid?"

And for your info, why this happened: There was no Bravearm64Universal.apk when I added Brave to FFUpdater.

Sepero commented 1 year ago

Sorry @Tobi823. I'll admit that I was a upset to discover that the Universal apk wasn't being used. Though I never meant to shame you or your work. It's true, the internet is global, so I'm glad you can understand it from my side as well. A good rule to follow is remarks on software should never, Never be taken personally.

I'm massively thankful for FFUpdater and your dedication to it. You are a good champion for many people.