search

Tobi823 / ffupdater

FFUpdater: Updater for privacy friendly browser
https://f-droid.org/en/packages/de.marmaro.krt.ffupdater
GNU General Public License v3.0
650 stars 32 forks source link

Tor Browser fails to find URL to check for update #511

Closed Devilbroz closed 11 months ago

Devilbroz commented 11 months ago

Describe the bug The application fails to find a specific URL when attempting to look for an update for the TOR Browser

To Reproduce Steps to reproduce the behavior:

  1. Open Application

Expected behavior I would expect to either see the application is updated or that there is an update available to install

Error message from FFUpdater Stacktrace:

java.lang.IllegalStateException: Can't find download url with regex pattern '(https://dist\.torproject\.org/torbrowser/(.+)/.+-android-aarch64-multi\.apk)'.
    at de.marmaro.krt.ffupdater.app.impl.TorBrowser.extractVersionAndDownloadUrl(SourceFile:14)
    at de.marmaro.krt.ffupdater.app.impl.TorBrowser.access$extractVersionAndDownloadUrl(Unknown Source:0)
    at de.marmaro.krt.ffupdater.app.impl.TorBrowser$extractVersionAndDownloadUrl$1.invokeSuspend(Unknown Source:12)
    at w3.a.resumeWith(Unknown Source:8)
    at j4.i0.run(Unknown Source:94)
    at m4.e.run(Unknown Source:11)
    at n4.j.run(Unknown Source:2)
    at n4.a$a.run(SourceFile:9)
Device information: Key Value
FFUpdater version 77.2.0 (113) release
Device Z6530V (VSBL_Z6530V, Z6530, spacexm)
Manufacturer ZTE (ZTE)
Supported ABIs arm64-v8a, armeabi-v7a, armeabi
Android version 9 (SDK: 28)
OS scl_xa242_074, unknown, release-keys, 1602225535000
Tobi823 commented 11 months ago

I found the issue and fixed it in version 78.2.5. It seems that you are using the FFUpdater version signed by F-Droid - but it will take some time until the fix is released on F-Droid.

You can either temporary uninstall the Tor Browser or install the latest version from Github/Gitlab (https://github.com/Tobi823/ffupdater/releases/tag/78.2.5, https://gitlab.com/Tobiwan/ffupdater_gitlab/-/releases/78.2.5)

Tobi823 commented 11 months ago

Or maybe you are using the FFUpdater version signed by me (aka Github version). Then you can:

Devilbroz commented 11 months ago

Amazingly fast work! Thank you so much!!

On Fri, Oct 13, 2023, 3:13 PM Tobias Hellmann @.***> wrote:

I found the issue and fixed it in version 78.2.5. It seems that you are using the FFUpdater version signed by F-Droid - but it will take some time until the fix is released on F-Droid.

You can either temporary uninstall the Tor Browser or install the latest version from Github/Gitlab ( https://github.com/Tobi823/ffupdater/releases/tag/78.2.5, https://gitlab.com/Tobiwan/ffupdater_gitlab/-/releases/78.2.5)

— Reply to this email directly, view it on GitHub https://github.com/Tobi823/ffupdater/issues/511#issuecomment-1762235278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFDL7N4S7DMTOIAO4OOU7LX7GVH5ANCNFSM6AAAAAA57JLUHQ . You are receiving this because you authored the thread.Message ID: @.***>

Devilbroz commented 11 months ago

How do I find your repository on F-Droid?

On Fri, Oct 13, 2023, 3:14 PM Tobias Hellmann @.***> wrote:

Or maybe you are using the FFUpdater version signed by me (aka Github version). Then you can:

— Reply to this email directly, view it on GitHub https://github.com/Tobi823/ffupdater/issues/511#issuecomment-1762236388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFDL7OD6E7YICP3CVK4CALX7GVNHANCNFSM6AAAAAA57JLUHQ . You are receiving this because you authored the thread.Message ID: @.***>

Tobi823 commented 11 months ago

https://github.com/Tobi823/ffupdater/blob/master/docs/other_distribution_channels.md#f-droid-repository

Tobi823 commented 11 months ago

I will create a short video to make it easier for all users

Devilbroz commented 11 months ago

I added your repo to F-Droid, but I don't see version 78.2.5 available

On Fri, Oct 13, 2023, 3:52 PM Tobias Hellmann @.***> wrote:

I will create a short video to make it easier for all users

— Reply to this email directly, view it on GitHub https://github.com/Tobi823/ffupdater/issues/511#issuecomment-1762284928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFDL7KJQVI5U6PN4GV2RSDX7GZ27ANCNFSM6AAAAAA57JLUHQ . You are receiving this because you authored the thread.Message ID: @.***>

Devilbroz commented 11 months ago

Got it!! Thanks so much!

On Fri, Oct 13, 2023, 3:52 PM Tobias Hellmann @.***> wrote:

I will create a short video to make it easier for all users

— Reply to this email directly, view it on GitHub https://github.com/Tobi823/ffupdater/issues/511#issuecomment-1762284928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFDL7KJQVI5U6PN4GV2RSDX7GZ27ANCNFSM6AAAAAA57JLUHQ . You are receiving this because you authored the thread.Message ID: @.***>

Tobi823 commented 11 months ago

Thanks and no problem :)

Uploading and showing a video on Github is more difficult than I thought. Anyway - the video is finally online https://github.com/Tobi823/ffupdater/blob/master/docs/other_distribution_channels.md#method-1