Tobi823 / ffupdater

FFUpdater: Updater for privacy friendly browser
https://f-droid.org/en/packages/de.marmaro.krt.ffupdater
GNU General Public License v3.0
647 stars 32 forks source link

FairMail Conflict with Google Play Permissions Version #533

Closed dreamsyntax closed 9 months ago

dreamsyntax commented 9 months ago

Important first questions

  1. Is your FFUpdater up-to-date? If not, please abort and update FFUpdater.

78.4.0 - issue introduced

Describe the bug FFUpdater now lists FairMail as an app. There is no option to exclude apps managed by FFUpdater.

If you have FairMail installed via Google Play Store FFUpdater will overwrite your app even with the signed difference option.

To Reproduce

  1. Install FairMail from Google Play Store
  2. Enable Hide apps that are signed by a different certificate
  3. FFUpdater still lists FairMail and constantly updates it, breaking the application since the Play Version has special permission that the raw apk does not for OAuth (see FairMail repo for info)

Expected behavior Allow for excluding apps even if detected on device.

ihatemakinganaccount commented 9 months ago

Similar problem for me with K-9 mail. I have a version I never wish to update with FFUpdater.

With the introduction of more apps like this, it's very important to allow users to exclude apps from updates, be it background or (accidental) foreground.

Tobi823 commented 9 months ago

I'm sorry - I was not aware that I could break existing installations. I though that the apps from Google Play Store would be signed with a different key

Tobi823 commented 9 months ago

How serious is the problem? Are any data lost? Can you simply disable background update of FFUpdater and install the correct version with Google Play?

Tobi823 commented 9 months ago

Quick fix: FFUpdater should only update apps automatically which where installed by FFUpdater

Tobi823 commented 9 months ago

@dreamsyntax Sorry, I did not read your comment fully.

Allow for excluding apps even if detected on device.

Is already implemented, but maybe to hidden.

dreamsyntax commented 9 months ago

How serious is the problem? Are any data lost? Can you simply disable background update of FFUpdater and install the correct version with Google Play?

Yes, you can disable background install as temporary measure. But I use many apps from FFUpdater, so I definitely want to keep the feature on in future.

Quick fix: FFUpdater should only update apps automatically which where installed by FFUpdater

This would be a sufficient fix IMO.

I'm sorry - I was not aware that I could break existing installations. I though that the apps from Google Play Store would be signed with a different key

I think this occurs if the developer is self managing keys? Not sure. I'll update the title since the issue is not the signed detection.

dreamsyntax commented 9 months ago

@dreamsyntax Sorry, I did not read your comment fully.

Allow for excluding apps even if detected on device.

Is already implemented, but maybe to hidden.

I guess I am not seeing where to enable this per app.

Tobi823 commented 9 months ago

@dreamsyntax Settings > Background > Exclude apps from update check

This will prevent that FFUpdater updates FairEmail etc. in the background.

But I'm improving the UI to make it simpler

M66B commented 9 months ago

I'm the author of FairEmail: can FairEmail please be removed from FFUpdater? It is causing only trouble, looking at the too many emails I've received about this.

It is also pointless because the F-Droid app is already checking for updates and the GitHub version of FairEmail is also checking for updates!

M66B commented 9 months ago

I'm sorry - I was not aware that I could break existing installations. I though that the apps from Google Play Store would be signed with a different key

You can't assume this! There are reproducible builds, etc.

dreamsyntax commented 9 months ago

I'm the author of FairEmail: can FairEmail please be removed from FFUpdater? It is causing only trouble, looking at the too many emails I've received about this.

It is also pointless because the F-Droid app is already checking for updates and the GitHub version of FairEmail is also checking for updates!

Not the author, but would you be ok with the proposed fix of:

FFUpdater should only update apps automatically which were installed by FFUpdater

As a FairMail user that would satisfy me. Just the rollout of 78.4.0 is what caused the issue for me. If it does not meddle with FDroid/Play in the future I'd be fine with it being in FFUpdater.

I think the intent is to encourage discoverability of your project within FFUpdater. As a user of FFUpdater I learned of some other browser forks I did not know existed, so I see the intent as positive.

Tobi823 commented 9 months ago

@M66B I added FairEmail to my app because some users wanted an easier method of using the Github version of FairEmail (#504).

Is it okay for you if:

M66B commented 9 months ago

@Tobi823 that's okay.

Tobi823 commented 9 months ago

Fix version is now released