Changing device orientation causes updater to start downloading gain

[marcel263]

FFUpdater 79.2.4

Describe the bug When the device orientation is changed, the download restarts.

To Reproduce Please insert the steps to reproduce the behavior here:

1. Manually updating a browser, here it's Firefox Nightly.

2. Rotate the device at any stage of the update process so it changes the orientation. The download starts again.

   modified the post to reflect how it also happens while downloading

[npahakis]

Happened to me, too.

1. Download starts normal.
2. After orientation change the progress percentage disappears
3. Turning it back has the percentage still missing
4. The progress bar starts anew but in the end it gets confused about the download and the app crashes

Here the stacktrace: Stacktrace:

java.lang.IllegalArgumentException: Downloaded or extracted APK file is not a valid ZIP file.
at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.checkApkFile(ApkDownloader.kt:155)
at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.access$checkApkFile(ApkDownloader.kt:21)
at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$checkApkFile$1.invokeSuspend(ApkDownloader.kt:0)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8762)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:604)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@6da8751, Dispatchers.Main]

Logs:

java.lang.IllegalArgumentException: Downloaded or extracted APK file is not a valid ZIP file.
at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.checkApkFile(ApkDownloader.kt:155)
at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$DefaultImpls.access$checkApkFile(ApkDownloader.kt:21)
at de.marmaro.krt.ffupdater.app.impl.base.ApkDownloader$checkApkFile$1.invokeSuspend(ApkDownloader.kt:0)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8762)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:604)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@6da8751, Dispatchers.Main]

Device information:	Key	Value
FFUpdater version	79.2.4 (174) release Github
Device	SM-G980F (x1seea, x1s, exynos990)
Manufacturer	samsung (samsung)
Supported ABIs	arm64-v8a, armeabi-v7a, armeabi
Android version	13 (SDK: 33)
OS	21DK7A21, dpi, release-keys, 1721973468000

[Tobi823]

Sorry for the late reply. I can reproduce the error

• rotating once restarts downloads
• rotating again will crash the app and I will fix it

[rafnov]

Got the same on me. Sorry for duplicate, didn't notice this thread.