search

Tobias-Fischer / rt_gene

RT-GENE: Real-Time Eye Gaze and Blink Estimation in Natural Environments
http://www.imperial.ac.uk/personal-robotics
Other
368 stars 68 forks source link

Accuracy increase in SolvePNP #101

Closed ahmed-alhindawi closed 3 years ago

ahmed-alhindawi commented 3 years ago

this commits adds the possibility of using an iterative solver after Ransac PNP solver which increases accuracy. I have only tested this qualitatively so I don't know about the % increase in accuracy but it seems more stable to me.

Have a play and see what you think...

Tobias-Fischer commented 3 years ago

Hey @ahmed-alhindawi - happy to merge this in, should we set the default to false though?

ahmed-alhindawi commented 3 years ago

Sure, default maintains backwards compatibility…

On 28 Jun 2021, at 21:36, Tobias Fischer @.**@.>> wrote:

This email from @.**@.> originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders listhttps://spam.ic.ac.uk/SpamConsole/Senders.aspx to disable email stamping for this address.

Hey @ahmed-alhindawihttps://github.com/ahmed-alhindawi - happy to merge this in, should we set the default to false though?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Tobias-Fischer/rt_gene/pull/101#issuecomment-870022820, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABU7YOPUV5TOGX6TQU7EPGTTVDMMJANCNFSM47OPAYNQ.