Closed ahmed-alhindawi closed 5 years ago
Thanks a lot @ngageorange! Things I want to check:
1) Can we get rid of use_mtcnn
completely now?
2) The RGB / BGR issue
Not sure when I'll get around to it though .. hopefully by the end of the week
And I'll update the licensing stuff
License is BSD-3; we're not redistributing the source code or redistributing the binary thus we don't need to add the license into the repo. I have however added a reference to it at the header
RGB/BGR issue resolves the image visualisation issue and has no perceptable impact on performance
MTCNN launch parameters have been removed as the ROS node no longer depends on them at all.
Thanks a lot! Great work.
Added face-landmarks package to extract 68 facial points in a cleaner fashion Also uses in-built face detector that's faster and produces less "jiggle" compared to MTCNN. Removed requirement for own-complied OpenCV Removed unnecessary functions and calls - still some refactoring required