Tobias-Fischer / rt_gene

RT-GENE: Real-Time Eye Gaze and Blink Estimation in Natural Environments
http://www.imperial.ac.uk/personal-robotics
Other
365 stars 68 forks source link

Download models if not existing #71

Closed Tobias-Fischer closed 4 years ago

Tobias-Fischer commented 4 years ago

Allow running estimate_gaze.py etc without having to run download_models.py; in that case, download the models at runtime.

ahmed-alhindawi commented 4 years ago

In addition, we now have diverging download structures, one in CMakeLists.txt and the other in the download_models.py. I have toyed with the idea of executing download_models.py once catkin_make is run but the output of execute_process isn't inlined with the output of catkin_make making it look like the whole thing has frozen, when it hasn't....

If we do move towards download_models.py as being our only way of downloading model files, we should think about removing the catkin_download bit in CMakeLists.txt

Tobias-Fischer commented 4 years ago

Yes, I agree that we should remove the catkin_downloads altogether .. when I first did this there was only one model so it was fairly quick, but now it has exploded and we shouldn't do it during the build process anymore.

Tobias-Fischer commented 4 years ago

I thought about this again. I suggest the following:

What do you think @ahmed-alhindawi? If you're happy with the suggestion I'll go ahead with it.

ahmed-alhindawi commented 4 years ago

Sounds great!