Closed tranb3r closed 1 year ago
Yes, I think you are right, so I will add this to the upcoming version 👍
Hi @TobiasBuchholz
I've tested my app again on iOS with version 2.0.1, and I still get the same exception.
I think the DocumentReferenceWrapper
code is still missing a call to ToNSObjectDictionary()
here:
https://github.com/TobiasBuchholz/Plugin.Firebase/blob/8dab85b15cb66fafd35c99b8b4806005f4c7eb6a/src/Firestore/Platforms/iOS/DocumentReferenceWrapper.cs#L24
Could you please double check and maybe fix it in the next version? Of course I can do the PR if you prefer, just let me know.
Thanks!
Yes, a PR would be much appreciated! :)
On iOS, when calling SetDataAsync on FireStore Document, I get the following exception if data contains a DateTime value:
I think the SetDataAsync method in DocumentReferenceWrapper (for iOS) should call ToNSObjectDictionary() before passing data to the SDK. This is how it's done in the UpdateDataAsync method (see similar issue #58). What do you think?