search

TobiasBuchholz / Plugin.Firebase

Wrapper around the native Android and iOS Firebase Xamarin SDKs
MIT License
220 stars 49 forks source link

Microsoft.CSharp dependency #143

Closed tranb3r closed 1 year ago

tranb3r commented 1 year ago

Hi,

Microsoft.CSharp is listed in Plugin.Firebase nuget's dependencies. Do you know why it's referenced in Plugin.Firebase.csproj? What is it used for? Can it be removed?

Thanks!

TobiasBuchholz commented 1 year ago

I actually can't remember why this dependency is included...removing it doesn't seem to cause any build problems and the tests are fine as well, so I will remove it at the next version 👍

tranb3r commented 1 year ago

@TobiasBuchholz Thank you for removing the Microsoft.CSharp dependency in version 2.0.0.

However, it's still pulled in by CloudMessaging. This is because you're using a dynamic type in DictionaryExtensions (in GetObject method). I think it would be a good idea to get rid of it, since it has a negative impact on apk size optimization. What do you think?

TobiasBuchholz commented 1 year ago

Changing the code to not using the dynamic keyword anymore wasn't very difficult, so the new version 2.0.1 shouldn't pull in Microsoft.CSharp anymore.