TobiasBuchholz / Plugin.Firebase

Wrapper around the native Android and iOS Firebase Xamarin SDKs
MIT License
220 stars 49 forks source link

Adding synchronous versions of WriteBatch.Commit() #208

Closed AdamEssenmacher closed 1 year ago

AdamEssenmacher commented 1 year ago

Adding synchronous versions of WriteBatch.Commit()

I specifically avoided using Commit as the method name for this synchronous overload to avoid false positives of static code analyzers that would flag it as having an async overload.

IMO, the ideal way to name these two methods would be CommitWithCompletionAsync and Commit. However, since the current method is named CommitAsync, I chose CommitLocal to avoid having it confused as a synchronous overload.