search

TobiasHennig / nativescript-toast

A NativeScript Toast Plugin for Android and iOS apps.
MIT License
67 stars 19 forks source link

use Toaster 2.1.1 that supports Swift4 #36

Closed championswimmer closed 6 years ago

championswimmer commented 6 years ago

fixes https://github.com/TobiasHennig/nativescript-toast/issues/34

farfromrefug commented 6 years ago

@hypery2k could you please merge and release this?

hypery2k commented 6 years ago

I merged, but CI build doesn't work, tried to fix it, but wasn't able to fix it within 3 hours - so have to postpone it

farfromrefug commented 6 years ago

@hypery2k can i help in any way? Can we see the CI error log?

hypery2k commented 6 years ago

you can try this branch: https://github.com/TobiasHennig/nativescript-toast/tree/bugfix/ci_build If it's getting through in travis that would help

seaware commented 5 years ago

Is there a solution for this? I upgraded to the latest v5 NativeScript and now get warning: Swift 3 mode has been deprecated and will be removed in a later version of Xcode. Please migrate "Toaster" to Swift 4.2 using "Convert > To Current Swift Syntax…" in the Edit menu. (in target 'Toaster'). FYI NativeScript installed Toaster v2.0.4 even though I explicitly asked for 2.1.1 as a dependency.

hypery2k commented 5 years ago

as long as it‘s just a warning no problem. But for Swift 4+ compatiblity create a new issue.

But right now Toaster doesn’t support Swift 4, see https://github.com/devxoul/Toaster/issues/139