search

TobiasRubel / Pathway-Reconstruction-Tools

2 stars 0 forks source link

Precision Recall code needs refractoring #4

Closed TobiasRubel closed 4 years ago

TobiasRubel commented 4 years ago

The PR code in Validation/PR/make_pr.py was built with K-shortest-paths-like algorithms in mind. It does not currently work unless the third column of an edges file is titled KSP index.

I see three possible fixes:

  1. index DataFrames by column number, rather than column name
  2. add in new column names to the code as they are needed
  3. only make use of the third column if there is a a column titled KSP index.

I'm inclined to go down route 3, since it makes it easiest on the user of the software.

TobiasRubel commented 4 years ago

Latest commits have fixed this problem. Closing.